PerlAlien / Alien-Build

Build external dependencies for use in CPAN
16 stars 25 forks source link

Test::Alien::Diag::alien_diag() testing for explicit method #365

Closed michal-josef-spacek closed 2 years ago

michal-josef-spacek commented 2 years ago

There is a situation with Alien::Brotli, which deliver new exe() subroutine, which returns the path to brotli tool. Should be good to present this result in alien_diag() method.

My proposal is to add an array of method names to alien_diag() or create another testing subroutine to handle these explicit methods.

plicease commented 2 years ago

This seems reasonable. alien_diag currently takes an array of alien names.

alien_diag('Alien::libfoo', 'Alien::libbar');

I think what we want is to recognize an optional options hash at the end.

alien_diag('Alien::libfoo', 'Alien::libbar', { properties => [ 'exe', ... ]);
michal-josef-spacek commented 2 years ago

Yes, that's possible.

FYI: I am trying to resolve https://github.com/robrwo/perl-Alien-Brotli/issues/4 and I have no information on what happens. Probably not related to this but to the brotli tool, which exits unexpectedly. I don't know how to check the root cause, still.

plicease commented 2 years ago

Proposed change was included in AB 2.68

michal-josef-spacek commented 2 years ago

Great, thank you. I created PR for Alien::Brotli (https://github.com/robrwo/perl-Alien-Brotli/pull/8)