PerlAlien / Alien-MSYS

Tools required for autogen scripts in Windows
1 stars 3 forks source link

Version string '1.60 ' contains invalid data #22

Open twata1 opened 1 year ago

twata1 commented 1 year ago

Hello,

Running Strawberry Perl 5.16.3 64 bit, I noticed the following message.

C:\home\pianokey>cpan PLICEASE/Alien-MSYS-0.16.tar.gz

(snip)

dmake.exe:  makefile:  line 757:  Warning: -- Empty recipe for special or meta target .NOTPARALLEL
dmake.exe:  makefile:  line 759:  Warning: -- Empty recipe for special or meta target .NO_PARALLEL
(C:\Strawberry\c\bin\dmake.exe exited with 0)
CPAN::Reporter: dmake result is 'pass', No errors.
  PLICEASE/Alien-MSYS-0.16.tar.gz
  C:\Strawberry\c\bin\dmake.exe -- OK
Version string '1.60 ' contains invalid data; ignoring: ' ' at C:\home\pianokey\perl5\lib\perl5/ExtUtils/MM_Unix.pm line 3032.
Version string '1.60 ' contains invalid data; ignoring: ' ' at C:\home\pianokey\perl5\lib\perl5/ExtUtils/MM_Unix.pm line 3032.
Running make test for PLICEASE/Alien-MSYS-0.16.tar.gz

(snip)

Thank you,

plicease commented 1 month ago

Does this happen in version 0.17 with gmake? dmake is deprecated and not bundled with newer versions of Strawberry. Absent a patch I am reluctant to spend time on this.

twata1 commented 1 month ago

Does this happen in version 0.17 with gmake?

No. I have checked on Strawberry Perl 5.36.3.1 64 bit.

Absent a patch I am reluctant to spend time on this.

OK. I respect your feelings.

twata1 commented 1 month ago

At the moment, I have just tracked it down to line 21 of the following file as the source of the cause. blib\lib\auto\share\dist\Alien-MSYS\msys\1.0\lib\perl5\5.8\CPAN\FirstTime.pm

line 21:

$VERSION = substr q$Revision: 1.60 $, 10;
twata1 commented 1 month ago

Hmmm. This also happens in Strawberry Perl 5.26.1 64 bit, which uses gmake. Update: So does Strawberry Perl 5.32.1 64 bit.

shawnlaffan commented 1 month ago

I cannot reproduce this on 5.16 when using cpanm.

Are you able to track down which part of the system is using the Perl 5.8 files from MSYS?

twata1 commented 1 month ago

@shawnlaffan

I cannot reproduce this on 5.16 when using cpanm.

I can not reproduce this on 5.16 when using cpanm either. The log file from that time can be found here. (Note: I use Strawberry Perl 5.16 via the HTTP->HTTPS conversion Proxy.) cpanm-Alien-MSYS-0.17-on-SP516.log.txt

Are you able to track down which part of the system is using the Perl 5.8 files from MSYS?

No. I inserted the warn statement at line 3007 of file MM_Unix.pm in ExtUtils::MakeMaker 7.71_01 as follows. I was just trying to find out where it was happening.

sub parse_version {
    my($self,$parsefile) = @_;
    my $result;
warn "--- $parsefile\n"
    local $/ = "\n";
    local $_;
    open(my $fh, '<', $parsefile) or die "Could not open '$parsefile': $!";

The above will cause the first part of the log to disappear, so here is the log when the output is suppressed as follows. cpan-Alien-MSYS-0.17-on-SP516.log.txt

sub parse_version {
    my($self,$parsefile) = @_;
    my $result;
warn "--- $parsefile\n" if $parsefile =~ /FirstTime/;
    local $/ = "\n";
    local $_;
    open(my $fh, '<', $parsefile) or die "Could not open '$parsefile': $!";

Thank you,