search

PerlAlien / File-Listing

Module to parse directoy listings
1 stars 3 forks source link

Add support for Windows listings with four-digit year format #26

Closed kwrightgsg closed 1 year ago

kwrightgsg commented 1 year ago

This date format has been an option available in the Windows Server FTP service since at least 2012, and possibly elsewhere. It is also supported by HTTP::Date as of 6.06.

plicease commented 1 year ago

Thanks for submitting this PR. I had two minor suggestions to get better diagnostics when the tests fail. I'm not sure why ok was being used in this subtest instead of is, but that was before my time.

The test failure is my fault, I apparently didn't get around to updating the CI config last year when I bumped the versions of Perl that I test against. Can you please rebase this PR onto the current main branch? It should then pass.

plicease commented 1 year ago

Thanks again for your contribution. This is included in version 6.16 and should be available from your local CPAN mirror shortly.