PerlDancer / Dancer

The easiest way to write web applications with Perl (Perl web micro-framework)
http://perldancer.org/
739 stars 211 forks source link

Use FindBin to work around the lack of '.' in @INC. #1195

Closed bigpresh closed 5 years ago

bigpresh commented 5 years ago

Tests had started failing on modern (>=5.26?) perls which don't have '.' in @INC.

Fixes #1194.

bigpresh commented 5 years ago

There's quite some cpantesters failures, but the first couple I've looked at at least are spurious ones where the smoker has proxy settings in their environment, so HTTP::Tiny is attempting to use that proxy to talk to localhost, and, obviously, failing.

We could either skip those Test::TCP/HTTP::Tiny using tests if $ENV{http_proxy} or similar are set, or tell HTTP::Tiny not to use a proxy, regardless of the env vars. The latter is probably better.

bigpresh commented 5 years ago

Actually, I've raised a PR with HTTP::Tiny - chansen/p5-http-tiny#118 - if that is accepted, it would make the problem go away with no changes in Dancer other than requiring that new HTTP::Tiny version when it ends up on CPAN. I'll see what feedback I get on it before deciding how to proceed.