PerlDancer / Dancer2

Perl Dancer Next Generation (rewrite of Perl Dancer)
http://perldancer.org/
Other
544 stars 274 forks source link

pod for Dancer2::Core::Hook mentions "apps" property that does not seem to exist #1574

Closed clemep-sios closed 3 years ago

clemep-sios commented 3 years ago

Quoting Dancer2/Core/Hook.pm:

=head2 register_hook ($hook_name, [$properties], $code)

    hook 'before', {apps => ['main']}, sub {...};

    hook 'before' => sub {...};

Attaches a hook at some point, with a possible list of properties.

Currently supported properties:

=over 4

=item apps

    an array reference containing apps name

=back

The apps property (or support for any properties being passed) does not seem to exist, the best I can tell.

Would a PR to update the POD in Dancer2::Core::Hook be welcomed?

racke commented 3 years ago

That is very much possible, as this part of the POD exists since Dancer2 was started. A PR would be certainly welcome.

clemep-sios commented 3 years ago

Here's the PR: https://github.com/PerlDancer/Dancer2/pull/1597

cromedome commented 3 years ago

Resolved. Thanks!