search

PerlDancer / Dancer2

Perl Dancer Next Generation (rewrite of Perl Dancer)
http://perldancer.org/
Other
543 stars 273 forks source link

disable scheduled GitHub action on forks #1581

Closed szabgab closed 3 years ago

racke commented 3 years ago

Can you please elaborate on this change, @szabgab ?

szabgab commented 3 years ago

In the previous version of the Github Actions the job is executed on push events, on pull requests, and also using the scheduler. This worked both in the central repository and on every fork as well. This pull request disables the scheduled execution on the forks. Or at least I hope it does that.

racke commented 3 years ago

OK, but what is wrong with running the action on your fork? Doesn't that need to enabled explicitly like for Travis?

szabgab commented 3 years ago

AFAIK it is enabled by default.

racke commented 3 years ago

Yes, that is true. Why is that a bad thing? With your change I can't run the actions on my fork if I want to.

szabgab commented 3 years ago

This change, if I am not mistaken, only disables the scheduled job on the forks. It will still run all the jobs hen you push new code to your fork.

racke commented 3 years ago

Yes, it still works on the fork when pushing commits there. :+1:

SysPete commented 3 years ago

:+1:

cromedome commented 3 years ago

Merged, thanks!