search

PerlDancer / Dancer2

Perl Dancer Next Generation (rewrite of Perl Dancer)
http://perldancer.org/
Other
543 stars 273 forks source link

Log files used to build config #1598

Closed 1nickt closed 3 years ago

1nickt commented 3 years ago

https://github.com/PerlDancer/Dancer2/issues/1593

1nickt commented 3 years ago

@cromedome This failure:

Unable to load class for Logger component Trap: Can't locate Dancer2/Logger/Trap.pm in @INC (you may need to install the Dancer2::Logger::Trap module) (@INC contains: /github/home/.cpanm/work/1615150101.14505/Dancer2-Plugin-Auth-Extensible-0.709/blib/lib /github/home/.cpanm/work/1615150101.14505/Dancer2-Plugin-Auth-Extensible-0.709/blib/arch /usr/local/lib/perl5/site_perl/5.32.0/x86_64-linux-gnu /usr/local/lib/perl5/site_perl/5.32.0 /usr/local/lib/perl5/vendor_perl/5.32.0/x86_64-linux-gnu /usr/local/lib/perl5/vendor_perl/5.32.0 /usr/local/lib/perl5/5.32.0/x86_64-linux-gnu /usr/local/lib/perl5/5.32.0 .) at /usr/local/lib/perl5/site_perl/5.32.0/Module/Runtime.pm line 314.
 at /usr/local/lib/perl5/site_perl/5.32.0/Dancer2/Core/App.pm line 215.
BEGIN failed--compilation aborted at t/no-login-handler.t line 17.
t/no-login-handler.t .................

is in a Auth::Extensible test. I first suspected that I was tripping an exception by calling $self->log indiscriminately, hence the second commit. The test still fails and I think the 2nd commit may be unneeded as I first thought.

1nickt commented 3 years ago

@cromedome @bigpresh Fix for bug in A::E test that is exposed by this change : https://github.com/PerlDancer/Dancer2-Plugin-Auth-Extensible/pull/96

cromedome commented 3 years ago

:+1: Thanks Nick!

1nickt commented 3 years ago

Opening a new PR with tests