Fix broken tests following App::Cmd removal

PerlDancer / Dancer2

Perl Dancer Next Generation (rewrite of Perl Dancer)

http://perldancer.org/

Other

544 stars 274 forks source link

Fix broken tests following App::Cmd removal #1607

Closed cromedome closed 3 years ago

cromedome commented 3 years ago

The Test::Compile plugin to Dist::Zilla tries to build a compile test with all of our modules, except now that we have removed the requirement for App::Cmd::Setup, App::Cmd::Setup might not be installed, and our test suite fails. This PR addresses the problem in two ways:

Excludes the Dancer2::CLI namespace from the automatic compile test generation
Builds a compiles test specifically for the CLI that skips all if App::Cmd::Setup is not installed

veryrusty commented 3 years ago

Let's add comments to dist.ini and the new test case flagging that these are temporary and can be undone/removed when #1319 is addressed.

SysPete commented 3 years ago

:+1: with @veryrusty's comment