search

PerlDancer / Dancer2

Perl Dancer Next Generation (rewrite of Perl Dancer)
http://perldancer.org/
Other
542 stars 274 forks source link

Add git features to Dancer2 CLI #1613

Closed cromedome closed 3 years ago

cromedome commented 3 years ago

This is the same PR as #1596, but redone to account for the new CLI. This offers the same feature set, but this time done with CLI::Osprey and Path::Tiny.

Please see the original PR for discussion.

racke commented 3 years ago

There are still http:// links present even after rebasing this branch on master:

If you need community assistance, the following resources are available:

racke commented 3 years ago

Also we should consider whether we start with "main" as default branch instead of "master".

bigpresh commented 3 years ago

Also we should consider whether we start with "main" as default branch instead of "master".

Maybe let the user decide if they want to bother with that, rather than forcing that on them?

racke commented 3 years ago

Also we should consider whether we start with "main" as default branch instead of "master".

Maybe let the user decide if they want to bother with that, rather than forcing that on them?

Fine for me.

cromedome commented 3 years ago

There are still http:// links present even after rebasing this branch on master:

If you need community assistance, the following resources are available:

Fixed. Not sure why those got lost in the rebase.

cromedome commented 3 years ago

Also we should consider whether we start with "main" as default branch instead of "master".

Maybe let the user decide if they want to bother with that, rather than forcing that on them?

I agree with that. That being said, should we change our master branch to main? Been wondering if I should just pull the trigger on that.

bigpresh commented 3 years ago

I agree with that. That being said, should we change our master branch to main?

Personally, I really don't see the point.

yanick commented 3 years ago

should we change our master branch to main?

That would be nice, yeah. :heart:

racke commented 3 years ago

should we change our master branch to main?

That would be nice, yeah. heart

At any rate, this question is not relevant to this ticket.

cromedome commented 3 years ago

Anyone see anything I missed on this PR? If not, can I get some approvals, and I will merge and release? Thanks :)

cromedome commented 3 years ago

Merged. Thanks everyone!