Proposal: Set minimum Perl to 5.10.1

PerlDancer / Dancer2

Perl Dancer Next Generation (rewrite of Perl Dancer)

http://perldancer.org/

Other

542 stars 274 forks source link

Proposal: Set minimum Perl to 5.10.1 #1627

Closed SysPete closed 3 years ago

SysPete commented 3 years ago

We can no longer install on 5.8 due to upstream dependencies, so I think it is time to admit defeat and bump our min dep. This also allows us to use defined-or and state variables.

Changes:

use 5.10.1 in Dancer.pm
add 5.10.1 dep to cpanfile
remove all mentions of 5.10 from docs when describing named captures
remove special-casing in code and tests for < 5.10

cromedome commented 3 years ago

:+1:... Very enthusiastically!

While I have no empirical proof, I suspect this affects a very small subset of our uses. 5.8 is 19 years old already! It's time to put support for it out to pasture. As it is, 5.10 is almost 15 years old... I think that is plenty far back for us to support. Especially given the useful features we get from making it or minimum version. Let's make this happen!

racke commented 3 years ago

I support it as well :+1: @SysPete Please check if we mention the minimum Perl version in the docs and adjust if needed.

SysPete commented 3 years ago

I've removed all mention of use of Perl < 5.10 from docs, and removed special-casing, as per updated initial comment. Docs do not specifically mention minimum Perl version, but that should show on metacpan due to MIN_PERL_VERSION in generated Makefile.PL.

cromedome commented 3 years ago

Thanks again! Sorry for the delay.