search

PerlDancer / Dancer2

Perl Dancer Next Generation (rewrite of Perl Dancer)
http://perldancer.org/
Other
537 stars 272 forks source link

Process hard deprecations #1696

Closed cromedome closed 10 months ago

cromedome commented 10 months ago

We're (well) past March now, when we could have hard deprecated these. Seems right before a 1.0.0 release.

cromedome commented 10 months ago

There are a few distributions that still depend on Dancer2::Test - should we submit PRs to provide an alternative as part of deprecating it?

SysPete commented 10 months ago

@cromedome I know of distros that will be broken by other deprecations. Please give me a couple of weeks to put something together that will give us a better view. I'm in favour of the change, but I don't want to feel like we behave like some other web frameworks. I, and others, have in the past put a lot of effort into helping plugin maintainers, and I'd prefer if we are seen as a framework that supports its contributors.

cromedome commented 10 months ago

@cromedome I know of distros that will be broken by other deprecations. Please give me a couple of weeks to put something together that will give us a better view. I'm in favour of the change, but I don't want to feel like we behave like some other web frameworks. I, and others, have in the past put a lot of effort into helping plugin maintainers, and I'd prefer if we are seen as a framework that supports its contributors.

Absolutely. I remember how much work went into Plugin2. How can we help? I don't want us to be seen as unhelpful either.

yanick commented 10 months ago

Please give me a couple of weeks to put something together that will give us a better view.

I appreciate the desire to be nice, but wasn't this marked to be deprecated for already a long, long time?

SysPete commented 10 months ago

Please give me a couple of weeks to put something together that will give us a better view.

I appreciate the desire to be nice, but wasn't this marked to be deprecated for already a long, long time?

Absolutely, just wanted a short time to try to judge the impact. There are a few dists that are affected, but most of what I'd call the primary plugins are OK, so all good from me.

cromedome commented 10 months ago

I've sent PRs for Dancer2::Plugin::Sixpack and Dancer2::Plugin::Browser. Dancer2::Template::Caribou is @yanick's (wink-wink-nudge-nudge), and Dancer2::Plugin::Syntax::GetPost is one that xdg left for us. Dist::Zilla is giving me some fits with that, but I am going to release a new version of that shortly.

That being said, I feel ok merging this. @SysPete if you want to post other dists that you know will be affected, please post them here and we can divide and conquer perhaps.

cromedome commented 10 months ago

And now Dancer2::Plugin::Syntax::GetPost is ready: https://github.com/PerlDancer/dancer2-plugin-syntax-getpost/pull/1

cromedome commented 10 months ago

Merged, thanks everyone!