search

PerlFFI / FFI-Platypus

Write Perl bindings to non-Perl libraries with FFI. No XS required.
89 stars 23 forks source link

Use parent instead of base #329

Closed jjatria closed 3 years ago

jjatria commented 3 years ago

The use of base is discouraged in favour of parent, which has been in core since 5.10. The only exception to this is for modules that use the also-discouraged fields pragma, but this is not the case for FFI::Platypus, so we can safely switch.

Please feel free to close this if there is some reason to prefer base instead for this distribution.

plicease commented 3 years ago

I’m ambivalent on this I guess. I’ve historically avoided parent because it is a non-core prerequisite on older Perls, but honestly 5.8 is old enough that if someone wants to use it they can install this and other prereqs. We will need to add it as a prereq though.

plicease commented 3 years ago

I’m ambivalent on this I guess. I’ve historically avoided parent because it is a non-core prerequisite on older Perls, but honestly 5.8 is old enough that if someone wants to use it they can install this and other prereqs. We will need to add it as a prereq though.

Not quite sure why Dist::Zilla isn’t pickup parent as a prereq.

jjatria commented 3 years ago

I’ve historically avoided parent because it is a non-core prerequisite on older Perls, but honestly 5.8 is old enough that if someone wants to use it they can install this and other prereqs

Yeah, I did fear it might come across as a little nit-picky, but I like seeing good distributions setting an example about what modules to use.

Not quite sure why Dist::Zilla isn’t pickup parent as a prereq.

Yeah, that's a little strange. I'll try to take a look and see if I can figure this out.

Thanks for the quick response!

plicease commented 3 years ago

When I get a chance I am going to try this out locally and kick the tires, but looks good so far.

jjatria commented 3 years ago

Thank you! I'm very glad to be able to contribute in whatever way I can.

And by the way, thank you for all the work you've put into this. FFI::Platypus is amazing! :D

plicease commented 3 years ago

Thank you for your contributions. BTW- Alien-Build is in a similar state for base/parent and it would be good to switch to parent there too if you are up to it :) https://github.com/PerlAlien/Alien-Build/