PerlFFI / FFI-Platypus

Write Perl bindings to non-Perl libraries with FFI. No XS required.
89 stars 23 forks source link

t/gh323.t: Skip all tests if variadic functions are not supported #343

Closed ppisar closed 3 years ago

ppisar commented 3 years ago

A new t/gh323.t test exhibits variadic functions (sprintf()). The test failed on systems which do not support them. (s390x with GCC 11 was reported).

This patch fixes it by skipping the test if the support is missing. A similar approach has already been used e.g. in t/ffi_platypus_function.t.

https://github.com/PerlFFI/FFI-Platypus/issues/342

plicease commented 3 years ago

Thanks for raising this. I think it would be good to add a configuration to CI where varadic is disabled, and then fix this so that it doesn't pop up again.

plicease commented 3 years ago

I used your commit in #345. First I updated CI to have a non-variadic config to verify that we'd catch this in the future. Thanks again for reporting this.