Note ahead, in the following comment @kthakore observed issues around pump_events that i do not understand fully, and i would love if he could find the time to provide input on this:
SHA-1: 4aa0251049879b65b9466ad638d32960967c5cf6
Need to pump before we poll to prevent skipping too many events before processing something
Often the need for calls to SDL_PumpEvents is hidden from the user
since SDL_PollEvent [...] implicitly call SDL_PumpEvents.
[...] if you are not polling or waiting for events [...]
you must call SDL_PumpEvents
This means that removing it should have no deleterious effects.
At the same time, its presence does seem to cause some. In the graph in this screenshot you will notice occasional red spikes at the bottom. These are caused by pump_events taking more time than ordinary, and disappear with (on Win7) no noticable side effects when pump_events is removed.
Given that clear benefit, i would like to see this commit released live in a production release to see if it causes ill effects for anyone using SDL.
Note ahead, in the following comment @kthakore observed issues around pump_events that i do not understand fully, and i would love if he could find the time to provide input on this:
SHA-1: 4aa0251049879b65b9466ad638d32960967c5cf6
That said, according to the documentation:
http://sdl.beuc.net/sdl.wiki/SDL_PumpEvents
http://sdl.beuc.net/sdl.wiki/SDL_PollEvent
This means that removing it should have no deleterious effects.
At the same time, its presence does seem to cause some. In the graph in this screenshot you will notice occasional red spikes at the bottom. These are caused by pump_events taking more time than ordinary, and disappear with (on Win7) no noticable side effects when pump_events is removed.
Given that clear benefit, i would like to see this commit released live in a production release to see if it causes ill effects for anyone using SDL.