PerlToolsTeam / github_workflows

Some useful (and reusable) GitHub Workflows
GNU General Public License v3.0
12 stars 0 forks source link

Improve "Run tests" step and question the use of prove #10

Closed XSven closed 3 weeks ago

XSven commented 3 weeks ago

This PR improves the "Run tests" step slightly. But: If we are using the different installers (Module::Build, ExtUtils::MakeMaker) to run the configure step (that's totally correct!) why are we not using them too to run the tests

./Build verbose=1 test   # if Module::Build is the installer
make TEST_VERBOSE=1 test # if ExtUtils::MakeMaker is the installer

Instead we are using prove?!

davorg commented 3 weeks ago

Instead we are using prove?!

Yes. Because until yesterday, I wasn't running the configure/build step :-)

XSven commented 3 weeks ago

OK I create another PR that removes prove!