search

Perlmint / glew-cmake

GLEW(https://github.com/nigels-com/glew, source updated nightly) with Cmake and pre-generated sources
Other
234 stars 95 forks source link

public include directory #12

Closed wang37921 closed 7 years ago

wang37921 commented 7 years ago

replace include_directories by target_include_directories let dependent auto include the glew include directory

Perlmint commented 7 years ago

It looks nice! but I have a simple request - fix the code style. I will happily merge it when you fix it. :)

wang37921 commented 7 years ago

fixed, have a look sorry about the git log, not familiar with it

Perlmint commented 7 years ago

Why did you make this redundant merge commit - 5df460a? It makes your changes weird. remove it, please.

Perlmint commented 7 years ago

I suggest that reset hard local master branch to ad431ac, and push force it to your remote repo.

example commands

git reset --hard ad431ac
git push -f origin master
wang37921 commented 7 years ago

thank you for your patience, check again^_^