Perlmint / glew-cmake

GLEW(https://github.com/nigels-com/glew, source updated nightly) with Cmake and pre-generated sources
Other
234 stars 95 forks source link

Fix cmake error on Linux "no LIBRARY DESTINATION" #18

Closed ArthurSonzogni closed 5 years ago

ArthurSonzogni commented 5 years ago

On Linux, cmake gives the error:

CMake Error at CMakeLists.txt:79 (INSTALL):
INSTALL TARGETS given no LIBRARY DESTINATION for shared library target
"libglew_shared".

CMake Error at CMakeLists.txt:94 (INSTALL):
INSTALL TARGETS given no LIBRARY DESTINATION for shared library target
"libglewmx_shared".

-- Configuring incomplete, errors occurred!

This bug was caused by the merge: e4de8a77a1f91aa99088187c7b8f7ff6bd6d107c

Containing:

The cause is that RUNTIME DESTINATION is now defined (for Windows), but not LIBRARY DESTINATION (for Linux).

See issue: https://github.com/Perlmint/glew-cmake/issues/17

Perlmint commented 5 years ago

I really appreciate you posted this PR quickly. Thanks!

ArthurSonzogni commented 5 years ago

Thanks for your review!