Perlmint / glew-cmake

GLEW(https://github.com/nigels-com/glew, source updated nightly) with Cmake and pre-generated sources
Other
234 stars 95 forks source link

Install libGLEW symbolic links #37

Closed Perlmint closed 3 years ago

Perlmint commented 3 years ago

Fix #36

SupervisedThinking commented 3 years ago

Thx for looking into it but I guess it won't work because you try to create the links before the actual libs were compiled and symlinks are created: https://github.com/Perlmint/glew-cmake/blob/f456deace7b408655109aaeff71421ef2d3858c6/CMakeLists.txt#L111-L118

Error:

-- Looking for IceConnectionNumber in ICE - found
CMake Error at CMakeLists.txt:120 (file):
  file failed to create symbolic link
  '/home/supervisedthinking/development/LibreELEC-RR/build.LibreELEC-Generic.x86_64-9.80-devel/build/glew-cmake-2.2.0/.x86_64-libreelec-linux-gnu/lib/libGLEW.so':
  no such file or directory

-- Configuring incomplete, errors occurred!
See also "/home/supervisedthinking/development/LibreELEC-RR/build.LibreELEC-Generic.x86_64-9.80-devel/build/glew-cmake-2.2.0/.x86_64-libreelec-linux-gnu/CMakeFiles/CMakeOutput.log".
FAILURE: scripts/build glew-cmake during configure_target (default)

Also I guess there is a / missing between ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}libGLEW.so in line: + file(CREATE_LINK "libglew.so" "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}libGLEW.so" SYMBOLIC)

Perlmint commented 3 years ago

Thx for looking into it but I guess it won't work because you try to create the links before the actual libs were compiled and symlinks are created:

https://github.com/Perlmint/glew-cmake/blob/f456deace7b408655109aaeff71421ef2d3858c6/CMakeLists.txt#L111-L118

Error:

-- Looking for IceConnectionNumber in ICE - found
CMake Error at CMakeLists.txt:120 (file):
  file failed to create symbolic link
  '/home/supervisedthinking/development/LibreELEC-RR/build.LibreELEC-Generic.x86_64-9.80-devel/build/glew-cmake-2.2.0/.x86_64-libreelec-linux-gnu/lib/libGLEW.so':
  no such file or directory

-- Configuring incomplete, errors occurred!
See also "/home/supervisedthinking/development/LibreELEC-RR/build.LibreELEC-Generic.x86_64-9.80-devel/build/glew-cmake-2.2.0/.x86_64-libreelec-linux-gnu/CMakeFiles/CMakeOutput.log".
FAILURE: scripts/build glew-cmake during configure_target (default)

Also I guess there is a / missing between ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}libGLEW.so in line: + file(CREATE_LINK "libglew.so" "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}libGLEW.so" SYMBOLIC)

Thanks for sharing the test result.

Now, It creates a symbolic link at the post-build time. I hope it will work now.

SupervisedThinking commented 3 years ago

LGTM

supervisedthinking@x220l:~/development/LibreELEC-RR$ ls -ls /home/supervisedthinking/development/LibreELEC-RR/build.LibreELEC-Generic.x86_64-9.80-devel/install_pkg/glew-cmake-2.2.0/usr/lib
insgesamt 700
  4 drwxrwxr-x 3 supervisedthinking supervisedthinking   4096 Feb  6 11:46 cmake
  0 lrwxrwxrwx 1 supervisedthinking supervisedthinking     16 Feb  6 11:46 libglew.so -> libglew.so.2.2.0
  0 lrwxrwxrwx 1 supervisedthinking supervisedthinking     10 Feb  6 11:46 libGLEW.so -> libglew.so
692 -rw-r--r-- 1 supervisedthinking supervisedthinking 706512 Feb  6 11:46 libglew.so.2.2.0
  4 drwxrwxr-x 2 supervisedthinking supervisedthinking   4096 Feb  6 11:46 pkgconfig