search

Perlmint / glew-cmake

GLEW(https://github.com/nigels-com/glew, source updated nightly) with Cmake and pre-generated sources
Other
234 stars 95 forks source link

Compilation error on macOS regarding symlinks #41

Closed janekb04 closed 3 years ago

janekb04 commented 3 years ago

After one of the commits regarding symlinks, the library seems to no longer compile on macOS. This Github Action run was performed on commit 7d525405e6abd0933f1a44c066645caea805f5d5 (before symlinks where intoduced). It compiles fine on Ubuntu and on macOS. On the other hand, this run uses the most recent commit and fails. The errors are:

[  9%] Linking C static library lib/libglew.a
create libGLEW symbolic link
make[3]: stat: external/glew-cmake/lib/libglew.a: Too many levels of symbolic links
[  9%] Built target libglew_static

and

Scanning dependencies of target glfwpp_example_basic
[ 86%] Building CXX object examples/CMakeFiles/glfwpp_example_basic.dir/basic.cpp.o
make[3]: stat: external/glew-cmake/lib/libglew.a: Too many levels of symbolic links
make[3]: *** No rule to make target `external/glew-cmake/lib/libglew.a', needed by `examples/glfwpp_example_basic'.  Stop.

It seems that one of the commits regarding symlinks broke something, though it's hard for me to tell which one.

Perlmint commented 3 years ago

Thank you for reporting the error! macOS uses the case-insensitive file system as default. It occurs this error. I created PR fixing this. It'll work with cmake macOS. If you don't mind, can you test it works on your environment?

janekb04 commented 3 years ago

Great, after changing to the new branch it works now.