PermanentOrg / node-sdk

Node.js SDK for Permanent.org
GNU Affero General Public License v3.0
4 stars 2 forks source link

Add copy/publish functions #31

Closed meisekimiu closed 2 years ago

meisekimiu commented 2 years ago
meisekimiu commented 2 years ago

I've finished up a wrapper method that lets the user call a copy method on a ChildItemVO without having to distinguish its type by hand. This also cleans up the example code.

cecilia-donnelly commented 2 years ago

@meisekimiu does this need a re-review at this point?

meisekimiu commented 2 years ago

Thanks for the review @cecilia-donnelly! Can you check the README changes I made real quick? (I think after this we should probably stop adding notes to the README but this change is a simple enough thing to document in the README).

cecilia-donnelly commented 2 years ago

Those README changes look great! I especially like that you noted that copying to the public root is equivalent to publishing.