search

Permify / permify

An open-source authorization as a service inspired by Google Zanzibar, designed to build and manage fine-grained and scalable authorization systems for any application.
https://permify.co/
Apache License 2.0
4.99k stars 225 forks source link

feat: new global tracer and meter #1743

Closed ucatbas closed 3 weeks ago

ucatbas commented 3 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

This pull request introduces significant modifications across multiple files to integrate a new internal telemetry system, replacing OpenTelemetry references with calls to internal.Tracer and internal.Meter. The changes affect the initialization of metrics and tracing spans in various components, including CheckEngineWithCache, DirectInvoker, DataServer, and several server implementations. The overall functionality and control flow of the systems remain intact, with no alterations to exported or public entity signatures.

Changes

File Path Change Summary
internal/engines/cache/check.go Removed otel imports; replaced meter and tracer with internal.Meter and internal.Tracer in NewCheckEngineWithCache and Check method.
internal/invoke/invoke.go Removed otel imports; replaced otel.Tracer and otel.Meter with internal.Tracer and internal.Meter; updated multiple methods to use the new tracer.
internal/monitoring.go Changed tracer and meter to Tracer and Meter, making them exported.
internal/servers/bundleServer.go Replaced tracer with internal.Tracer in Write, Read, and Delete methods.
internal/servers/dataServer.go Updated histogram metrics to use internal.Meter; replaced tracer with internal.Tracer in multiple methods.
internal/servers/permissionServer.go Replaced tracer with internal.Tracer in several methods.
internal/servers/schemaServer.go Updated NewSchemaServer to use internal.Meter; replaced tracer with internal.Tracer in multiple methods.
internal/servers/server.go Removed tracer and meter declarations.
internal/servers/tenancyServer.go Replaced tracer with internal.Tracer in Create, Delete, and List methods.
internal/servers/watchServer.go Added import for internal; updated Watch method to use internal.Tracer.
internal/storage/memory/tracer.go Deleted file containing OpenTelemetry tracer for memory.
internal/storage/postgres/bundleReader.go Updated Read method to use internal.Tracer.
internal/storage/postgres/bundleWriter.go Replaced tracer with internal.Tracer in Write and Delete methods.
internal/storage/postgres/dataReader.go Updated multiple methods to use internal.Tracer.
internal/storage/postgres/dataWriter.go Replaced tracer with internal.Tracer in Write, Delete, and RunBundle methods.
internal/storage/postgres/schemaReader.go Updated multiple methods to use internal.Tracer; added import for internal.
internal/storage/postgres/schemaWriter.go Added import for internal; updated WriteSchema method to use internal.Tracer.
internal/storage/postgres/tenantReader.go Added import for internal; updated ListTenants method to use internal.Tracer.
internal/storage/postgres/tenantWriter.go Replaced tracer with internal.Tracer in CreateTenant and DeleteTenant methods.
internal/storage/postgres/tracer.go Deleted file containing OpenTelemetry tracer for PostgreSQL.
internal/engines/check.go Enhanced error handling in checkDirectRelation and checkDirectAttribute methods for permission checks.
internal/engines/expand.go Improved error handling in expandDirectAttribute and expandDirectRelation methods.
internal/engines/subjectFilter.go Added error handling and restructured methods for clarity and functionality.
pkg/cmd/serve.go Enhanced error handling in the serve function for configuration loading and other components.
pkg/database/postgres/postgres.go Improved error handling and logging in PostgreSQL connection pool management.

Possibly related PRs

Suggested reviewers

Poem

🐰 In the meadow, changes bloom,
Internal systems chase the gloom.
With metrics bright and traces clear,
Our code hops forth, no need to fear!
A telemetry tale, we weave with glee,
For every bunny, a better spree! 🌼

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between a6abc32a4b84e9c2f7d8a0ed5d1c73ec4c949967 and f011909bb7176b488e6dfb08658de0e83fa86875.
📒 Files selected for processing (6) * `internal/engines/check.go` (0 hunks) * `internal/engines/expand.go` (0 hunks) * `internal/engines/subjectFilter.go` (0 hunks) * `internal/storage/postgres/tenantWriter.go` (3 hunks) * `pkg/cmd/serve.go` (0 hunks) * `pkg/database/postgres/postgres.go` (0 hunks)
💤 Files with no reviewable changes (5) * internal/engines/check.go * internal/engines/expand.go * internal/engines/subjectFilter.go * pkg/cmd/serve.go * pkg/database/postgres/postgres.go
🚧 Files skipped from review as they are similar to previous changes (1) * internal/storage/postgres/tenantWriter.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.