search

Pernosco / pernosco

General-purpose public wiki and issue tracking
12 stars 0 forks source link

Search bar view proposals don't handle overflow cases involving lambdas well #36

Closed asutherland closed 3 years ago

asutherland commented 3 years ago

I'm not honestly entirely sure what's going on here, but if you open up this mozilla pernosco link and search on OpenDatabaseOp::LoadDatabaseInformation you will see something like this image

If you check out the code you'll see we use lots of cool (nested) lambdas inside it and these seem to result in very long pretty-printed symbols that may be at the root of the problem.

khuey commented 3 years ago

The #searchDropdown > buttons are not overflow: hidden. Their contents are, but that doesn't seem to matter (maybe this is an interaction with flexbox?)

Even after adding overflow: hidden on those it's not amazing but it's definitely far less insane.

asutherland commented 3 years ago

Thanks! I applied the CSS and (as in your screenshot) that's a pretty good improvement and lets me find the actual method without all the lambdas all over the place!

khuey commented 3 years ago

Separately, we should probably figure out a way to rank lambdas lower here.

khuey commented 3 years ago

This will be fixed next time we deploy.

The "real" function is already ahead of all the lambdas, so I think we're good there too.