search

PerseusDL / canonical-greekLit

XML Canonical resources for Greek Literature
https://scaife.perseus.org
Creative Commons Attribution Share Alike 4.0 International
100 stars 94 forks source link

(tlg0003-trans) adding new translations of Thucydides and adding the books 5-8 of Zevort (opp-fre1) #1473

Closed gregorycrane closed 1 year ago

gregorycrane commented 1 year ago

This pull request does two things.

  1. It adds the remaining books of Zevort's French translation (we only had volume 1 with books 1-4).

  2. It adds a number of translations that have languished for up to 15 years. This is a big step.

  3. I have used my own automatic tests to check the XML. Whatever I missed, I will add to those checks if possible.

  4. As always, I made sure these pass hooktest on my machine before the pull request.

earlier notes below

I am finally going to add to Thuc translations that have sat for years. A number of translations have been posted in Scaife but we have more that have been languishing.

I need URNs for. Some may be in the online catalog but I don't know if they are what we want to use now.

AlisonBabeu commented 1 year ago

Hi @gregorycrane , so we have been in the habit of creating new URNs for editions using 1st1K or OGL depending on the text and the collection, unless it is an updated Perseus edition. A number of these do have URNs in the catalog, but a number may be invalid due to the inability to update the metadata or the interface for so long. I’ve also long wanted to revisit renumbering all of the Thucydides URNS, since they don’t make logical sense (lat17, may be 1 of 4 Latin editions), but that is for another issue and another conversation.

So I'd use as follow:

gregorycrane commented 1 year ago

I really really don't want to create a new folder in First1KGreek for Thuc -- there is no tlg0003 now. I want to keep these in canonical-greekLit, even if we use those URNs.

AlisonBabeu commented 1 year ago

I don't think you would need to. The updated Perseus editions that are found in 1st1K Greek all still live in the canonical-greekiLit.

lcerrato commented 1 year ago

Did you want to mint URNs with "perseus" in them? This folder already contains files without "perseus" in the name. I don't think we restrict the naming practice based on repo location.

AlisonBabeu commented 1 year ago

We don't and of course there is no reason we could not just give these Perseus URNs of course (I'm not into simple solutions today!)

gregorycrane commented 1 year ago

I found another German translation: It looks like tlg0003.tlg001.1st1K-ger4 is still free and I will use that if I don't hear otherwise.

     <monogr>
        <title>Die Rede des Perikles für die Gefallenen</title>
        <author>Thucydides</author>
        <respStmt>
          <name>Rudolf G. Binding</name>
          <resp>translator</resp>
        </respStmt>
        <imprint>
          <pubPlace>Mainz-Kastel</pubPlace>
          <publisher>Hanns Marxen</publisher>
          <date>1937</date>
lcerrato commented 1 year ago

Was this fixed? I see several PRs referencing it

AlisonBabeu commented 1 year ago

hi @lcerrato yes I edited all the Thucydides files and changed some of the URNs. I believe all of the Thucydides files should be correct and complete (as far as that goes)