search

PerseusDL / canonical-latinLit

XML Canonical resources for Latin Literature
https://scaife.perseus.org
Creative Commons Attribution Share Alike 4.0 International
42 stars 56 forks source link

phi1348_take_two #528

Closed AlisonBabeu closed 1 year ago

AlisonBabeu commented 1 year ago

hi @lcerrato continuing work on Suetonius started a while ago following guidelines of closed pull request and email. Updated cts_.xml, headers, and bibliographic metadata including new links.

Will continue sending in batches if these changes are acceptable.

AlisonBabeu commented 1 year ago

hi @lcerrato one more question, as I've gone through the ENglish files, in some cases the author's note was taken out and in others it was not. Should I just leave them as they are for the moment or would it be worth removing them, even though I am not sure what I would do with them....

lcerrato commented 1 year ago

@AlisonBabeu Can you give me an example of what you mean?

AlisonBabeu commented 1 year ago

hi @lcerrato most of the English translations include a few paragraph or more of an author's note. for some reason, phi1348.phi022.perseus-eng2 the file actually concludes at the end of the translation whereas for example phi1348.phi021.perseus-eng2 includes an entire author's note from lines 409 to 444.

lcerrato commented 1 year ago

@AlisonBabeu These files need a comprehensive review as they were a part of the initial conversion process, so reviewing for content should probably be done within the larger context of bringing these up to the current best practice standards.

AlisonBabeu commented 1 year ago

hey @lcerrato ok, I think I will be happy to take charge of that, but for the moment let me just make sure all the changes i made for headers and cts_.xml are correct and the files pass. I already started editing the files by deleting numerous place name errors.

lcerrato commented 1 year ago

@AlisonBabeu Ok, I would have to do a deeper dive to see what else is missing from this markup.