search

PerseusDL / canonical-latinLit

XML Canonical resources for Latin Literature
https://scaife.perseus.org
Creative Commons Attribution Share Alike 4.0 International
42 stars 56 forks source link

phi1348_all_files #529

Closed AlisonBabeu closed 1 year ago

AlisonBabeu commented 1 year ago

Next bath of Suetonius.

lcerrato commented 1 year ago

@AlisonBabeu Taking a step back for a minute:

  1. both volumes use the full author name C. Suetonius Tranquillus, but neither monograph tag has this.
  2. the author name in the cts workgroup is just Suetonius, but the top level author name in the files themselves is C. Suetonius Tranquillus, which is ok, just a little inconsistent. (FWIW I would stick with Suetonius in those places). So I think that the formal name and the short name are in the wrong places based on other files?
  3. there are some Latin names/titles (Augustus, Caligula, etc.) that are either untagged or tagged as English. In other places where a name could be either (such as many workgroups) I've seen Latin as the default assumption. Again, just something that seems confusing. I guess if the word/anme can be found in the Latin dictionary, I would tag it as Latin? (Again, thinking out loud here).
  4. I can't drill down on most of the text/body revisions so I'm assuming they are ok. Looks like the reformatting is too extensive to permit word level change review in some cases.
lcerrato commented 1 year ago

@AlisonBabeu I would probably just go ahead with this as is and do a separate pass (or two) to revise any naming issues.

AlisonBabeu commented 1 year ago

hi @lcerrato so I get the changes to make here.

1 and 2, I will change the names in the locations per your suggestions. 3 I will revert to Latin for all those title names unless it is a transformation to English such as Domitianus to DOmitian. 4.I can promise you I made no textual changes to the Latin texts of Suetonius and I will never use pretty print absentmindedly again.

Thanks!

lcerrato commented 1 year ago

@AlisonBabeu I think the changes to the body of the text are needed, but as a separate pass. Just thinking that having something changed across the whole corpus may be better than doing these small batches because I can see any inconsistencies much easier, but I think it might be better as one type of change per batch? (So one pass for the author name, one pass for editor, one pass for titles, etc.)

AlisonBabeu commented 1 year ago

hey @lcerrato I do agree and moving forward when I start with an author I will start with one type of change across files in a batch, but for the moment let me fix these and submit an updated pull request with all the files.