search

PerseusDL / catalog_pending

Repository to hold new catalog source data pending integration into catalog_data
2 stars 2 forks source link

is grc a valid language@objectPart value? #8

Closed balmas closed 8 years ago

balmas commented 8 years ago

@AlisonBabeu I've encountered something I'm not sure about wrt to handling of language when importing a mods file

This file in catalog pending has a language element with an objectPart value of 'grc': correct for https://github.com/PerseusDL/catalog_pending/blob/master/mods/Herodotus/herodotus.Teubner%28Dietsch-Kallenberg%29.Historiae.mods.xml#L41

We would end up not knowing what language to attribute to the version identified by this mods file, because the the only objectPart value we consider valid is "text". If it didn't have an objectPart at all, then we would use the language specified here, but because it has an objectPart and it isn't text, we assume it's describing something other than the text.

AlisonBabeu commented 8 years ago

That is just a plain old error on my part. Whoops.