search

PerseusRipple / prj-rev-bwfs-dasmoto

1 stars 0 forks source link

Summary #7

Open tommygebru opened 5 years ago

tommygebru commented 5 years ago

Overall Exceeds Expectations Hey Perseus great work on your project Dasmotos About Linking: Looking over your code I can see that you used good html structure as well as css. Your css is linked to the html page and uses an appropriate file path

About Structure: Your documents both have good hierarchy for the page structure, your css is a cascading stylesheet, so anything written at the bottom of the page will be applied/recognized therefore overriding a previous style written above it.

The html structure use some divs to group smaller and appropriately sectioned elements. This is known as nesting elements within the parent, or wrapping children elements within a container.

About Syntax: Syntax is our grammar and spelling of code, if there are any errors in your code it would show in your browser and can negatively affect the desired outcome. There were little to no errors in your code but i encourage you to always take more time to revise for errors (code checking is how we spend half our time 😆 ).

Ok - Great work overall Perseus I suggested some things to bookmark or simply keep in mind to improve your project: For your editor of choice, include a linter extension or plugin (a syntax-checker) for your coding language, this will save you hours if not days of work!! 😋

Lastly keep some HTML/CSS best practices in mind when coding https://www.codecademy.com/articles When in doubt Google it (or MDN it) 🎉

PerseusRipple commented 5 years ago

Thank you, Tommy, for such a thorough and timely review.

You know, I was so excited to have finished that I submitted the project without rest/edit or peer review. As a creative writing undergrad, I should've known better but am so glad to have the awakening now--like all good writing, code is so much about the revision. (This is language, after all).

Thank you too for the links.

Not quite sure how to use the ampersands you suggested in the html and h1s. I will continue to Google as well as refer to my book.

You've given me much to ponder and be excited about. The detailed feedback is appreciated, Tommy. Thank you!!

tommygebru commented 5 years ago

Of course Perseus 👌 keep up the good work and happy coding !