search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Fixes for current 1.16.3 Forge #105

Closed clockler closed 3 years ago

PersonTheCat commented 4 years ago

It's been a long time since I got one of these on a personal project. I really, really appreciate your help! I'm working from home today, so hopefully I can review this in a bit.

clockler commented 4 years ago

I should have noted: this has a regression in that in-config loot tables don't work anymore with these changes, as I wasn't able to find an easy way to fit them in with transitioning the config loot table definition to use a ResourceLocation to be parsed later. They can still be declared in a custom datapack with OpenLoader or similar, or they could be loaded in a FMLCommonSetupEvent handler as I was doing before? They just need to be parsed as loot tables after the RegistryEvents are fired.

PersonTheCat commented 4 years ago

I can merge the changes from 4b92ce6 and 2e7980c, but I'm not sure I understand what's going on with the loot table changes. This field is supposed to be optional and is only needed when the user wants to explicitly define the loot table from within the preset. Otherwise, it should just get the drops directly from ore and thus these changes aren't needed. Could you elaborate on that?

PersonTheCat commented 3 years ago

I believe everything but the loot changes have been implemented in the main branch. Gonna have to reject. Feel free to reopen this and we can continue discussion. Thanks again for your help!