PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

(1.16.4) Textures don't load for some people #109

Closed RegalRuffRaff closed 3 years ago

RegalRuffRaff commented 3 years ago

Just downloaded the 1.16.4 version of the mod, and everything works as it should except the textures, which use the 'texture missing' textures.

PersonTheCat commented 3 years ago

Experiencing a lot of issues and inconsistent crashes now when using Optifine. Had to try a couple different versions of Optifine until the game would even load. That being said, I still have not seen any missing textures, but I do suspect that it has something to do with Optifine.

@WenXin20 I tried removing the mod from my mods folder and, after reading the logs, it seems to have just installed itself. I'm wondering if that may be what happened with your instance as well.

WenXin20 commented 3 years ago

I didn't have optifine installed, I checked the video settings and it was only the vanilla settings.

PersonTheCat commented 3 years ago

Any way you could send the log? I was still seeing Optifine in the logs, but not in game.

WenXin20 commented 3 years ago

I just ran it with No other mods, and the textures are still missing. Log

I sent it a couple of comments ago.

PersonTheCat commented 3 years ago

Oh, you're right. Thanks! Still not sure.

WenXin20 commented 3 years ago

In the pack.mcmeta, the pack format number for 1.16.4 is 6, but in the file it is set to 3. Could that be why this is happening?

GnomTocha commented 3 years ago

Launched only osv without other mods(also without Optifine). Forge 35.1.28 debug.log latest.log 2021-01-12_19 17 14

GnomTocha commented 3 years ago

Tried the mod with forge 35.1.36 without any other mods and the problem persists. Then I changed tlaucher to official mojang. Unfortunately, nothing has changed.

PersonTheCat commented 3 years ago

Just wanted to give a quick update and say that I've now tried running this mod in 4 different environments, 2 different computers, 3 different operating systems, and once in a virtual machine. I've tried running it directly in my IDE, by downloading it manually from CurseForge, and through the Overwolf launcher. I have still not experienced this issue even once. If anyone here has access to a second computer or operating system where they can test this a second time, please try that and update me with the results.

This is officially one of the most complicated bugs I've ever experienced and I can't fix it until I can figure out what's causing it. I was hoping this would be a race condition that I could just find and fix, but I feel confident at this point that we can rule that out. I'm at a stalemate now and don't believe there's much else I can do.

RegalRuffRaff commented 3 years ago

It's been a while, but as of 1.11, the problem still randomly persists. Most often, it seems to happen when the mod tries to make Ore blocks using the Quark stones.

Edit: I have tried it on a laptop, and it seems to randomly happen there too. If the textures don't load upon startup, they never will, and when they do, you can't quit and rejoin a world without them breaking again.

PersonTheCat commented 3 years ago

I've worked really, really hard to reproduce this issue. Across 3 machines, one virtual machine, and two different operating systems (not counting distributions), this problem just does not occur for me.

That being said, version 6.0 will be out soon. One of the biggest features it introduces is concrete JSON model generation, meaning the new models will load just like all the others provided the resource pack is enabled in time. It is also working for me, but it hasn't really been thoroughly tested by other people. I'll share a build of that here tonight for anyone who wants to try it out and see if the problem goes away.

RegalRuffRaff commented 3 years ago

Hopefully that will finally solve the issue. Sorry you've had to go through so much for a problem that seemingly doesn't exist for your side.

PersonTheCat commented 3 years ago

Definitely! This is without a doubt the most elusive problem I've ever seen. Sometimes I genuinely wonder if it actually exists because I've just never seen it. I know it does, though. Hopefully these models will do it!

PersonTheCat commented 3 years ago

Here's the latest build for anyone who wants to help me test. Note that this includes some of the biggest changes I've ever made to the mod internally. I'm expecting quite a few bugs to still be around (and especially crashes), but on the surface, everything is working for me!

Ore Stone Variants-6.0-Jeremiah.zip

Let me know especially if you try this out and the textures are or are not working for you now. Be aware that resources.zip no longer exists and was replaced with a directory, resources. This is intended to avoid problems with anti-virus software and other processes opening the file while the mod is still attempting to write into it.

Also, feel free to join the Discord server because I'll be posting updates to this file over the next few days in preparation for a release. Thanks for your help!

RegalRuffRaff commented 3 years ago

Okay, everything seems to be working fine now! This version seems to work pretty well, I tried out a few worlds and it seems to load in each time.

2021-02-26_21 41 08

PersonTheCat commented 3 years ago

Hey, thanks for the update! This is really great news. I think a couple of us are still experiencing the issue over on Discord, but I'm really relieved to hear there's at least some improvement.

PersonTheCat commented 3 years ago

This ticket has gone through a lot of changes yet again. While there could be some improvements to compatibility with other mods, I currently believe that these textures are working as expected, and thus I am closing this issue for now.

Because I never experienced this problem firsthand, it may come back up in a later version of the mod (6.1+). If that is the case, please create a new issue and we'll look back into it.

Thanks everyone for your help on this issue! This was tough.