search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

JEI Compatibility Issue #110

Closed WenXin20 closed 3 years ago

WenXin20 commented 3 years ago

Minecraft v1.16.4 Forge v35.1.36 OSV v5.11

I decided it would be better to create a new issue for this. I got a crash in JEI when searching @osv and when going to the creative tab for the dense ore variants. It seems to be related to adding sandstone to the blockgroup. The reports also mention optifine (pre12) and obfuscate (required for the vehicles mod). JEI Crash Report Creative Tab Crash Report

PersonTheCat commented 3 years ago

I don't consider this a bug since it has to do with other mods, but I will look into it.

This is a reminder that I have not experienced this problem and cannot reproduce it.

WenXin20 commented 3 years ago

Yes, I know. I'll see if I can find which mod causes it.

WenXin20 commented 3 years ago

Any idea what mods could potentially cause this? I tried replicating it in a fresh instance, but I've had no luck with the mods mentioned in the crash reports.

WenXin20 commented 3 years ago

I still haven't figured out what caused the crash, I tried splitting the modpack up to check for what could cause it, but none of the mods crashed it. The only thing I haven't tried is on a server. Were you able to test on a server?

PersonTheCat commented 3 years ago

No, I didn't think about that. It shouldn't crash because none of the textures or block models are actually loaded on servers, but I'll give it a try.

WenXin20 commented 3 years ago

I was able to replicate the crash in singleplayer with this modpack everytime when using JEI or opening the creative tab. I've tried all day yesterday to narrow down the mods, but I've been unable to, which has been incredibly frustrating. I'm wondering if the crash is happening because of the amount of items listed in JEI. https://drive.google.com/file/d/1hnjwZ3eBxr-o69xCf54CA76JDb7MCZAi/view?usp=sharing

PersonTheCat commented 3 years ago

Just curious, did you try it without OSV? If so, did it still crash? If it is only crashing with OSV installed, I will take another look tonight. If not, this is probably a bug with JEI and not OSV.

WenXin20 commented 3 years ago

No, I haven't yet. But it crashes when opening the osv creative tab too. Also, this line: https://gist.github.com/WenXin20/3fc22776932abca2177e6347756db308#file-osv_crash-txt-L68

PersonTheCat commented 3 years ago

@WenXin20 Can you confirm if this issue still occurs?

WenXin20 commented 3 years ago

No crashes so far with jei. I forgot about this to be honest. :D

PersonTheCat commented 3 years ago

Awesome! Thanks for the quick response!