search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Game Crash On Loading - Concurrent Modification Exception #125

Closed Sixdd6 closed 3 years ago

Sixdd6 commented 3 years ago

Basically as the title says, log is posted here

For reference I am attempting to load with a x256 texture pack with Optifine installed, not sure if that old texture issue is still relevant or not.

PersonTheCat commented 3 years ago

Hello. I have been aware of this issue for some time and have just recently begun working on a fix for it. The problem is that I can't verify it because this does not occur for me. You can try this new build out below and let me know if the problem goes away. Make sure to try it multiple times because this is not a guaranteed crash as it has to do with multithreading and is essentially random.

If the problem does not go away when using this new build, I really cannot fix it unless we can narrow this issue down to a single mod that causes the problem. If the problem is coming from Optifine, I will not fix it.

In any case, I hope this works! Let me know how it goes if you try it out and thanks in advance for your help!

Ore_Stone_Variants-6.2.zip

Sixdd6 commented 3 years ago

I'll give it a try right now.

Sixdd6 commented 3 years ago

So far, Minimal environment with forge and optifine, loaded fine 10 out of 10 times. 200+ mod environment with optifine, loaded fine 10 out of 10 times.

Seems you've fixed it.

PersonTheCat commented 3 years ago

Awesome! Thanks for your help. The next update is a bug fix update for 1.16, so let me know if you encounter any other issues and I'll patch em up.

PersonTheCat commented 3 years ago

I've actually implemented a different fix for this issue in 6.2. The collection that was throwing this exception is no longer even getting modified. It's definitely a bit of a hack, but that's what it took to make this error completely impossible in the newer versions. I'll close this now.