PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
6 stars 8 forks source link

Ore Block loot tables not being modified by other mods #126

Closed ildiem closed 3 years ago

ildiem commented 3 years ago

Hello! I'm running Minecraft 1.16.5 with Forge ver. 36.1.16 and Ore Stone Variants 6.1.

I'm running the mod alongside Caves & Cliffs Backport, which includes new loot tables for Iron and Gold Ore to allow them to drop Raw Iron and Raw Gold. The mod stores these loot tables under "minecraft", but OSV doesn't pull from these new loot tables when it seems to be pulling from those files by default. Does C&C Backport not modify those loot tables directly, or is there some order of operations thing which prevents OSV from accessing the modified loot tables?

I don't believe this is a bug so much as I don't have enough knowledge to understand the problem. I was hoping someone may provide some insight as to how to fix this? Thanks!

PersonTheCat commented 3 years ago

OSV lets you modify the loot tables in two ways:

Basically, if you don't use a raw JSON, the location is passed into the regular block properties and OSV does not determine where the loot comes from beyond that point.

In other words, to fix this, there are two options:

In my opinion, the second option is not a good choice because then I'm reimplementing behavior that is already supposed to happen in the base game. I'd prefer to never do that, if I can avoid it.

I'll take a look after 6.2 comes out, but will most likely not change this behavior. OSV has to generate everything and is designed to handle drops, block property overrides, and custom ore generation. It's very highly specialized to avoid redundant setup between multiple ores of the same type, something that no other ore mod does. It's gonna conflict with any mod that tries to change that.

ildiem commented 3 years ago

Thanks for the quick reply and all the info! I think I have an idea of where to go from here, so please don't worry about looking at the second option. Thanks again!