search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
6 stars 8 forks source link

Fix compatibility for Forge Endertech's Large Ore Deposits. #129

Closed Kaleidio closed 2 years ago

Kaleidio commented 2 years ago

Your generator constantly throws error, leading to the server using as much as 5 Gigabytes per second throughput, and logspamming until it's in the hundreds of megabytes.

it's so ungodly large...it even says optifine threw a few opengl exceptions with your renderer too.

[19:54:35] [Server thread/ERROR]: Error adding element: Value 64 outside of range [0:10] over. and over. and over. for millions of lines.

Using Kaleidio's Battle Pack at the time.

PersonTheCat commented 2 years ago

This is a user error and should be fixed. One of your ores has a cluster size of > 64, which is not allowed. I think it's actually supposed to crash. You need to reduce your cluster size.

In the future, I will support larger cluster sizes in the form of a new generator, but this is an unrelated ticket.

I'll leave this open temporarily for visibility.

Kaleidio commented 2 years ago

That's not my problem. That's caused by a mod called Large Ore Deposits. The mod actively overrides the size cap of ore deposits and that's why it refuses to crash; your mod alone is complaining because your code still thinks that size isn't allowed.

Relabel this as "compatibility" please.

PersonTheCat commented 2 years ago

Sure. Thanks for the clarification.