search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Some ores didn't copy the tags correctly #140

Open frank89722 opened 2 years ago

frank89722 commented 2 years ago

OSV-7.1 forge 36.2.22

As title, some ores have no problem (mekanism uranium) image

But some ores only have the #forge:ore tag (vanilla iron) image

PersonTheCat commented 2 years ago

Is iron ore supposed to have additional tags? It literally just takes from the original ore and copies them. None of it is hard coded.

frank89722 commented 2 years ago

Vanilla iron ore has the forge:ores/iron tag. And mekanism uranium ore in OSV have the correct tag but osmium didn't image

Seems like it could be a race condition?

(My English is not good so I apologize if my words sound rude, I really appreciate your work!)

PersonTheCat commented 2 years ago

No worries. Hmm, I doubt it's a race condition because most mods don't register tags manually (you're not supposed to). Minecraft usually handles all of that for you and then OSV basically changes the tags after it's done. So, I'm not sure, but I'll take a look at it before 7.2.

PersonTheCat commented 2 years ago

I have started working on dynamic tag support for OSV 1.18 and may be able to backport the feature to 1.16. Will update here if so, but things are moving quite slowly these days due to a few major life changes.