PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

[1.12.2] Resource Pack with OSV #166

Closed reddvilzz closed 2 years ago

reddvilzz commented 2 years ago

Hi there, I'm on 1.12.2 and was wondering since I'm using some resource pack, is there anyway to make the ore stone variants to blend in with the different stone textures I'm using?

I'm using Modernity-format3-v3.7.0.zip and Vanilla_Future_Texture_optifine.zip for the resource pack.

here is the example

and here is my config if needed. (Had to change it to .log instead so it can be uploaded here.)

PersonTheCat commented 2 years ago

@reddvilzz In OSV 5.x, the models are loaded dynamically. The background layer is copied directly from the origin model at runtime, so it should already use that texture. Are you using any shaders? It looks like it might just be a lighting issue, which can happen with shaders since these blocks render in the translucent render layer.

reddvilzz commented 2 years ago

Okay found out why is it causing funny stuff. If the resource pack have color.properties in it this will happen if the stone is not defined. In my case the color.properties from my resource pack used to differentiate colors for each biomes temp and making my stone using that color temp.

so I just add palette.block.~/colormap/stone.png= in my color.properties which I think defines the colormap for stone to still use it's original color.

PersonTheCat commented 2 years ago

@reddvilzz Thanks! Sounds like this is an Optifine behavior. Thanks for clarifying. I would typically leave this kind of issue open for visibility, but I don't anticipate other users running into the same kind of issue anytime soon, so I will be closing it. Please let me know if you encounter any other issues and we'll try to work em out.