search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Crash on loading without resources generated #27

Closed pupnewfster closed 6 years ago

pupnewfster commented 6 years ago

https://paste.dimdev.org/atekotosuf.mccrash And a different crash I am getting sometimes instead while trying to load (using the 3.0.3 version you sent) https://paste.dimdev.org/emoderavah.mccrash

List of custom ores: https://i.gyazo.com/97a98ac71e5e57a1c112bddf13b94dbe.png

PersonTheCat commented 6 years ago

Are any of those new since you started crashing, or is that new since 3.0.+? If it's the version, I might be able to figure it out. Otherwise, I'll have to send you a diagnostic build to figure out what's actually working and when it stops.

pupnewfster commented 6 years ago

The first one I got once on 3.0.0 the second one I only have gotten on the 3.0.3 version.

And I what happened is I removed my versions of thermal foundation ores because I decided to remove thermal foundation all together.

PersonTheCat commented 6 years ago

Here's a debug build. Just run this and send me the full log. It should hopefully indicate which file is trying to load, get copied, etc. Also, which ore it's doing it for, which PropertyGroup it belongs to, and a bunch of other random pieces of information.

Thanks.

ore_stone_variants-3.0.5.zip

pupnewfster commented 6 years ago

latest.log

Another solution may be to add a config option to not do furnace mapping given I don't use it anyways.

PersonTheCat commented 6 years ago

I see. So, it definitely is related to the ore dictionary crash and not the texture loading crash. I wonder if this is related to the changes I was talking about earlier. I'll just change them back, for now. Let me think about this for a bit.

Edit: I don't see that line in CraftTweaker's code, either. The name can't be null, because it's in a loop, so it must be the block. But it doesn't make sense for the block to be null either, because I've already validated some of its properties before getting to this point. This may take me a minute, if it isn't just the mod name issue.

pupnewfster commented 6 years ago

I actually managed to figure it out. In a script I have that modifies the ore dictionary a little I by mistake still was referencing one of the ores that I had removed. After removing it from the script it works properly now.

PersonTheCat commented 6 years ago

Oh, great! Thanks for letting me know.