search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Crash with HammerX mod #59

Closed Bulldog83 closed 5 years ago

Bulldog83 commented 5 years ago

I've taken the crash when I've try to broke some of your ore with hammer from HammerX.

There are 4 crash logs.

https://gist.github.com/Bulldog83/7264833f819d58da11e8dea877462227

Minecraft: 1.12.2 Forge: 14.23.5.2768 OSV: 4.3 HammerX: 1.1.4

PersonTheCat commented 5 years ago

Hey, there. Thanks for reporting this! I'm honestly not sure why this might occur, but I suspect it's more on the side of HammerX than OSV. I'll be taking a deeper look at this at some point to see what I can do to mitigate it. In the meantime, you may be able to avoid the crash by disabling background block imitation in the config file. This will make variants function just like normal ores, avoiding the code that crashes.

Bulldog83 commented 5 years ago

As far as I understand from the logs, your block returns incorrect value.

PersonTheCat commented 5 years ago

Correct, but it appears that this happens when non-OSV blocks are polled as though they were OSV blocks. According to the crash, it's trying to get properties from minecraft:stone and minecraft:air by calling BlockOresBase#getMaterial, which of course yields various crashes. I believe there isn't really all that much I can do to work around this. :/