search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Vanilla generation is blocked in non-whitelisted dimensions #70

Open Azmalent opened 5 years ago

Azmalent commented 5 years ago

No stones or ores generate in Atum when "Replace Vanilla Ore and Stone Generation" option is on, even though the dimension is not whitelisted. This probably affects other dimensions as well.

PersonTheCat commented 5 years ago

Are any dimensions whitelisted? If not, I believe ores are allowed to generate anywhere. If you do have some dimensions listed, this is something I can look into, but it'll have to be after I finish moving and potentially get a working build of the rewrite for 1.14 first.

Azmalent commented 5 years ago

Yes, I had other dimensions in the whitelist, but not this one.

PersonTheCat commented 5 years ago

Looking back at this, this functionality essentially was intended. Ores are technically allowed to generate anywhere when the whitelist is empty, but only Ore Stone Variants' ores. Vanilla ores' getting disabled in all dimensions is just the result of how Forge's GenerateMinable event works. There's no way to control which dimensions or biomes are allowed to generate specific ores using the standard API. I'm sure there's some way I can achieve this--either via reflection or by replacing all vanilla ore generators with my own--but I think that would be outside of the scope of this mod, for the time being. :/ At least for what is now an older version of the game.