search

PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

1.12 #76

Closed SpGilbert closed 5 years ago

SpGilbert commented 5 years ago

Are there any other files I need to edit for this pull request to add the other two types of stone from quark to be added to the base mod?

PersonTheCat commented 5 years ago

Hey, thank you so much for your contribution! It's almost all. BlockInit is missing the check for quarkJasperOn and then the two entries need to be added to BlockGroup#DEFAULT_GROUP_INFO so they can show up by default. That was kept in a super bizarre location, though, I know. The mod definitely needed to be restructured a bit and that's what I'm working on now with the rewrite for 1.14.

Anyway, I'll fix those two things when I get a minute later today and upload to CurseForge. Thanks again for your contribution!

SpGilbert commented 5 years ago

Do you need me to finish any other files for that since I only now have my pc up since I was doing a data transfer

PersonTheCat commented 5 years ago

It should be good, actually, but thank you!

SpGilbert commented 5 years ago

Well I hope you remember to upload it to curseforge

PersonTheCat commented 5 years ago

Looks like it's still under review, for some reason. Hopefully it'll get approved by tomorrow.

SpGilbert commented 5 years ago

ok

SpGilbert commented 5 years ago

and it seems they have not approved it

PersonTheCat commented 5 years ago

It seems fine to me. Here's the link I have. https://www.curseforge.com/minecraft/mc-mods/ore-stone-variants/files/2780602

SpGilbert commented 5 years ago

oh didn't see it must have missed it