PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Can't generate ores only on certain mineralogy rocks using OSV...(1.12.2) #91

Closed dobbyjang0 closed 4 years ago

dobbyjang0 commented 4 years ago

I tried to generate ores only on certain mineralogy rocks with Ore Stone Variant, but it doesn't work... I edit config like that as a test,

blockregistry {
# Whether to test the block registry for duplicate combinations.
B:testForDuplicates=true
S:values <
minecraft mineralogy
>

Maybe an issue where the Mineralogy mod is loaded after OSV mod? I don't know much about mods... (I'm using OSV v5.3, Mineralogy v3.8.0.53)

dobbyjang0 commented 4 years ago

I found these option in the Mineralogy mod config,

    # If true, then the world will be patched to fix compatibility-breaking changes to this mod by adding-back mock-ups of old obsolete blocks and then replacing obsolete blocks with newer blocks. [default: true]
    B:patch_world=true

I change that option true and false, it still doesn't work...

dobbyjang0 commented 4 years ago

and I find a missing list of Mineralogy block in OSV config, here's all the Mineralogy mod stone list

        S:mineralogy <
            mineralogy:granite
            mineralogy:basaltic_glass
            mineralogy:siltstone
            mineralogy:peridotite
            mineralogy:basalt
            mineralogy:rock_salt
            mineralogy:quartzite
            mineralogy:conglomerate
            mineralogy:gneiss
            mineralogy:rhyolite
            mineralogy:diabase
            mineralogy:scoria
            mineralogy:shale
            mineralogy:marble
            mineralogy:tuff
            mineralogy:dolomite
            mineralogy:chalk
            mineralogy:pegmatite
            mineralogy:chert
            mineralogy:pumice
            mineralogy:amphibolite
            mineralogy:schist
            mineralogy:phyllite
            mineralogy:limestone
            mineralogy:novaculite
            mineralogy:andesite
            mineralogy:hornfels
            mineralogy:slate
            mineralogy:diorite
            mineralogy:gabbro
         >

I copy-paste that and run again, still doesn't work

dobbyjang0 commented 4 years ago

I edit config like that,

    S:values <
        minecraft mineralogy
     >

picture

and only mineralogy ores do spawn....

PersonTheCat commented 4 years ago

Do you mean OSV's ore types are only spawning in Mineralogy's stone types? If so, it's because you removed the other stone types from the block list. You should be able to replace minecraft mineralogy with default default and the rest of the ores will spawn again because mineralogy is a default block group.

dobbyjang0 commented 4 years ago

@PersonTheCat

Do you mean OSV's ore types are only spawning in Mineralogy's stone types? If so, it's because you removed the other stone types from the block list. You should be able to replace minecraft mineralogy with default default and the rest of the ores will spawn again because mineralogy is a default block group.

Sorry for lacking my English skill and insufficient explanation. No, That case doesn't spawn vanilla ores. My final purpose is certain ores be generated on certain Mineralogy's stone. (For example, Iron ore must be generated in limestone layers. like that) So, I tried to like this (I put mineralogy:limestone in the test group)

    S:values <
        minecraft test
     >

but it doesn't work. then I tried that

    S:values <
        minecraft mineralogy
     >

Both cases doesn't generate Minecraft ores (and don't disable mineralogy ores generation) Is the basic syntax like "<ore> <background>."? So that example must generate vanilla ores? But it doesn't work...

dobbyjang0 commented 4 years ago

@PersonTheCat Is this a real bug? or I have a miss-understanding and am I doing wrong? I want to use Dynamic Blocks features. I'm struggling with this problem so many times... I spent my whole week to solve this problem. please help me...

PersonTheCat commented 4 years ago

Okay, so I have tested this and everything is definitely working fine for me. The only issue is that sometimes regular stone variants spawn in the new Mineralogy stone types, but this has to do with how late Mineralogy replaces stone underground and I don't think I can fix that. The Mineralogy devs would most likely need to change when stone gets placed underground to improve compatibility. However, It does still work.

I'm not really sure what you mean. Do you mean the game is crashing? Are no ores spawning at all? Is it just the original vanilla ores (e.g. minecraft:coal_ore)? Is it the new OSV ores (e.g. osv:coal_ore)? Make sure you remove mineralogy from disableVanillaWhen if you still want vanilla OSV ore variants to spawn and then let me know.

Hope this helps!

dobbyjang0 commented 4 years ago

I remove mineralogy from disableVanillaWhen, It worked! thank you for helping me! I can disable regular stone variants spawn in the new Mineralogy stone types, simply change config\osv\stone files. Thank you!