PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

thaumcraft ore wrong image and rendering layers #97

Open Biviho opened 3 years ago

Biviho commented 3 years ago

first of all, this is with the mod used right away, without any changes in config.

there is a problem with thaumcraft ores: basically they are rendered a lot more darker and with a string item on top of it.

the second problem is that all the ores from the mod render on top of potion whirls, not all the ores, only the detail, the stone is fine, but it is weird to see

PersonTheCat commented 3 years ago

Hello! Sorry for taking so long to get back to you. I believe the problem with Thaumcraft ores is related to their texture paths being changed. You should be able to work around this by changing texture.original inside of the presets to reflect the new path. If that doesn't work, let me know and I'll take a look at it.

Thanks!

Edit: the second issue is related to the ores being rendered in the translucent layer. This is necessary to get the full range of opacity I need for nice looking overlays. It's definitely a bit of a tradeoff. You can try disabling it in the config file under blocks.translucentTextures and seeing if that works better for you. In the meantime, this issue was fixed in later MC versions thanks to improvements in the render engine.

Biviho commented 3 years ago

i'm suddenly become really busy and didn't look deep in the mod config, i will try to get on it soon

Biviho commented 3 years ago

i managed to find the problem in thaumcraft texture: the "texture" voice was set to "builtIn: true", changing it to thaumcraft:blocks/ore_amber (the same for cinnabar) fixed the problem, i will ow look into the rendering layer problem

Edit: i also had to add "shade" propriety to false, it appear that immersive engineering and bop blocks that didn't had that propriety have a black outline around the ore detail ( i had to add this propriety to thaumcraft blocks too, didn't noticed it was also this that was needed). Setting shade to false did fix this problem, but there is not anymore the nice blend to stone that the normal ore have. Adding back "Builtin: true" have no effect.

Also, there is still a problem with immersive engineering now: some points get grey colored on the stone surface, this is pretty evident on slate from quark for example.

setting translucentTexture to false did fix the problem with the rendering after potions swirl

reddvilzz commented 2 years ago

Hi there I'm having the same issue, and when I changed the original texture to thaumcraft:blocks/ore_amber the game would crash saying java.lang.RuntimeException: There is no block named "thaumcraft:blocks/ore_amber."

what should I fill the original.texture with on the config? or am I changing the wrong config? is it supposed to be in thaumcraft_amber_ore.hjson? I'm on 1.12.2. @PersonTheCat

Edit: Okay managed to fix it, I forgot to add the texture section for it, instead I was changing the original ore.