search

Personal-Data-Linkage-Module / pxr-operator-service

MIT License
1 stars 2 forks source link

commit modified version bugfix/#16 #19

Closed kentaro000 closed 9 months ago

kentaro000 commented 10 months ago

概要

対処内容

パッケージのバージョンアップ内容

nodeJS, npm, postgresバージョン

$ node --version
v18.16.0
$ npm --version
9.5.1
$ psql --version
psql (PostgreSQL) 12.16

補足

コマンド実行結果

npm install実行結果

$ npm install
npm WARN deprecated @types/helmet@4.0.0: This is a stub types definition. helmet provides its own type definitions, so you do not need this installed.
npm WARN deprecated @babel/plugin-proposal-export-namespace-from@7.18.9: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-export-namespace-from instead.
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142

added 988 packages, and audited 989 packages in 2m

155 packages are looking for funding
  run `npm fund` for details

2 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

ビルド実行結果

$ npm run build

> operator-service@1.0.0 build
> npm-run-all -s lint build:ts

> operator-service@1.0.0 lint
> eslint ./src/index.ts src/**/*.ts

> operator-service@1.0.0 build:ts
> node ./node_modules/typescript/bin/tsc

UT実行結果

$ npm run test:unit

> operator-service@1.0.0 test:unit
> jest --coverage --forceExit --detectOpenHandles --runInBand --config=jest.unit.config.js --logHeapUsage

PASS src/tests/13-01.UserInfo.spec.ts (32.265 s, 594 MB heap size)
PASS src/tests/01-01.OperatorAdd.spec.ts (6.178 s, 737 MB heap size)
PASS src/tests/04-01.OperatorUpdate.spec.ts (6.923 s, 501 MB heap size)
PASS src/tests/06-01.OperatorLogin.spec.ts (5.47 s, 618 MB heap size)
PASS src/tests/05-01.OperatorDelete.spec.ts (717 MB heap size)
PASS src/tests/16-01.IndSmsVerificate.spec.ts (668 MB heap size)
PASS src/tests/12-01.RoleAndAuth.spec.ts (770 MB heap size)
PASS src/tests/11-01.SecurityTest.password.spec.ts (864 MB heap size)
PASS src/tests/06-04.OperatorLogin.spec.ts (968 MB heap size)
PASS src/tests/10-01.PasswordReset.spec.ts (1064 MB heap size)
PASS src/tests/02-01.OperatorGetByType.spec.ts (1173 MB heap size)
PASS src/tests/04-02.OperatorUpdate.libgetOperatorError.spec.ts (1007 MB heap size)
PASS src/tests/07-01.OperatorOneTimeLogin.spec.ts (1107 MB heap size)
PASS src/tests/01-02.OperatorAdd.libgetOperatorError.spec.ts (1206 MB heap size)
PASS src/tests/17-01.SsoLogin.spec.ts (1303 MB heap size)
PASS src/tests/03-01.OperatorGetById.spec.ts (1402 MB heap size)
PASS src/tests/09-01.OperatorSession.spec.ts (1270 MB heap size)
PASS src/tests/06-02.OperatorLogin.GeneratesSessionIdIfAlreadyUse.spec.ts (1365 MB heap size)
PASS src/tests/15-01.IdentifyCode.spec.ts (1455 MB heap size)
PASS src/tests/04-04.OperatorUpdate.libisAllAuthMemberExistsOtherThisIdError.spec.ts (1547 MB heap size)
PASS src/tests/05-04.OperatorCancelDelete.spec.ts (1638 MB heap size)
PASS src/tests/16-02.IndSmsVerificateVerifiy.spec.ts (1735 MB heap size)
PASS src/tests/08-01.OperatorLogout.spec.ts (1564 MB heap size)
PASS src/tests/14-01.RequestArrayValidator.spec.ts (1658 MB heap size)
PASS src/tests/05-03.OperatorDelete.RequestFromAnotherUser.spec.ts (1758 MB heap size)
PASS src/tests/06-03.OperatorLogin.GeneratesLoginIdIfAlreadyUse.spec.ts (1856 MB heap size)
PASS src/tests/04-03.OperatorUpdate.libisSessionIdExistsError.spec.ts (1945 MB heap size)
PASS src/tests/05-02.OperatorDelete.libgetOperatorError.spec.ts (1788 MB heap size)
-------------------------------------------------|---------|----------|---------|---------|---------------------------------
File                                             | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-------------------------------------------------|---------|----------|---------|---------|---------------------------------
All files                                        |   98.53 |    97.43 |   99.75 |   98.48 |
 repositories/postgres                           |   97.93 |    92.85 |     100 |   97.85 |
  IdentifyCodeEntity.ts                          |   67.85 |        0 |     100 |   65.38 | 51-59
  IdentifyCodeRepository.ts                      |     100 |      100 |     100 |     100 |
  LoginHistory.ts                                |     100 |      100 |     100 |     100 |
  LoginHistoryOperation.ts                       |     100 |      100 |     100 |     100 |
  ManageBlockInfo.ts                             |     100 |      100 |     100 |     100 |
  OneTimeLoginCodeEntity.ts                      |     100 |      100 |     100 |     100 |
  OneTimeLoginCodeRepository.ts                  |     100 |      100 |     100 |     100 |
  OperatorEntity.ts                              |     100 |      100 |     100 |     100 |
  OperatorRepository.ts                          |   98.01 |    84.61 |     100 |   98.01 | 527,561
  PasswordHistory.ts                             |     100 |      100 |     100 |     100 |
  PasswordHistoryOperation.ts                    |     100 |      100 |     100 |     100 |
  RoleSettingEntity.ts                           |     100 |      100 |     100 |     100 |
  RoleSettingRepository.ts                       |     100 |      100 |     100 |     100 |
  SessionEntity.ts                               |     100 |      100 |     100 |     100 |
  SessionRepository.ts                           |     100 |      100 |     100 |     100 |
  SmsVerificationCode.ts                         |     100 |      100 |     100 |     100 |
  SmsVerificationCodeOperation.ts                |     100 |      100 |     100 |     100 |
  UserInformationEntity.ts                       |     100 |      100 |     100 |     100 |
  UserInformationRepository.ts                   |     100 |      100 |     100 |     100 |
 resources                                       |     100 |      100 |     100 |     100 |
  IdentifyCodeController.ts                      |     100 |      100 |     100 |     100 |
  LoginController.ts                             |     100 |      100 |     100 |     100 |
  LogoutController.ts                            |     100 |      100 |     100 |     100 |
  OperatorController.ts                          |     100 |      100 |     100 |     100 |
  PasswordController.ts                          |     100 |      100 |     100 |     100 |
  SessionController.ts                           |     100 |      100 |     100 |     100 |
  SmsVerificateController.ts                     |     100 |      100 |     100 |     100 |
  UserInfoController.ts                          |     100 |      100 |     100 |     100 |
 resources/dto                                   |    99.1 |    96.25 |   98.64 |   99.09 |
  GetByOperatorIdResDto.ts                       |   97.67 |    94.11 |     100 |   97.67 | 102
  GetOperatorWithTypeReqDto.ts                   |     100 |      100 |     100 |     100 |
  IdAAsOperatorOrUserReqDto.ts                   |     100 |      100 |     100 |     100 |
  NewPasswordReqDto.ts                           |     100 |      100 |     100 |     100 |
  OperatorIdReqDto.ts                            |     100 |      100 |     100 |     100 |
  PostAddUserInformationReqDto.ts                |     100 |      100 |     100 |     100 |
  PostIdentifyCodeReqDto.ts                      |     100 |      100 |     100 |     100 |
  PostIndLoginOneTimeReqDto.ts                   |     100 |      100 |     100 |     100 |
  PostIndLoginReqDto.ts                          |     100 |      100 |     100 |     100 |
  PostIndLoginSsoReqDto.ts                       |     100 |      100 |     100 |     100 |
  PostIndSmsVerificateReqDto.ts                  |     100 |      100 |     100 |     100 |
  PostIndSmsVerificateVerifiyReqDto.ts           |     100 |      100 |     100 |     100 |
  PostLoginReqDto.ts                             |     100 |      100 |     100 |     100 |
  PostLoginResDto.ts                             |     100 |      100 |     100 |     100 |
  PostLogoutReqDto.ts                            |     100 |      100 |     100 |     100 |
  PostOperatorAddReqDto.ts                       |     100 |      100 |     100 |     100 |
  PostOperatorAddResDto.ts                       |   96.36 |    92.85 |     100 |   96.36 | 133,148
  PostSessionReqDto.ts                           |     100 |      100 |     100 |     100 |
  PostSessionResDto.ts                           |     100 |      100 |     100 |     100 |
  PostUserInfoListReqDto.ts                      |     100 |      100 |     100 |     100 |
  PostUserInfoSearchReqDto.ts                    |     100 |      100 |     100 |     100 |
  PostUserInfoSearchResDto.ts                    |     100 |      100 |     100 |     100 |
  PutByOperatorIdReqDto.ts                       |     100 |      100 |     100 |     100 |
  PutByOperatorIdResDto.ts                       |     100 |      100 |     100 |     100 |
  UserInformationDto.ts                          |   96.15 |      100 |    87.5 |   96.15 | 47
 resources/validator                             |     100 |      100 |     100 |     100 |
  GetByOperatorTypeRequestValidator.ts           |     100 |      100 |     100 |     100 |
  IdAsOperatorOrUserValidator.ts                 |     100 |      100 |     100 |     100 |
  LoginRequestValidator.ts                       |     100 |      100 |     100 |     100 |
  OperatorIdParamsValidator.ts                   |     100 |      100 |     100 |     100 |
  PostIdentifyCodeRequestValidator.ts            |     100 |      100 |     100 |     100 |
  PostIndLoginOneTimeRequestValidator.ts         |     100 |      100 |     100 |     100 |
  PostIndLoginRequestValidator.ts                |     100 |      100 |     100 |     100 |
  PostIndLoginSsoRequestValidator.ts             |     100 |      100 |     100 |     100 |
  PostIndSmsVerificateRequestValidator.ts        |     100 |      100 |     100 |     100 |
  PostIndSmsVerificateVerifiyRequestValidator.ts |     100 |      100 |     100 |     100 |
  PostLoginOneTimeRequestValidator.ts            |     100 |      100 |     100 |     100 |
  PostLoginSsoRequestValidator.ts                |     100 |      100 |     100 |     100 |
  PostOperatorAddRequestValidator.ts             |     100 |      100 |     100 |     100 |
  PostSessionRequestValidator.ts                 |     100 |      100 |     100 |     100 |
  PostUserInfoListRequestValidator.ts            |     100 |      100 |     100 |     100 |
  PostUserInfoRequestValidator.ts                |     100 |      100 |     100 |     100 |
  PostUserInfoSearchRequestValidator.ts          |     100 |      100 |     100 |     100 |
  PutOperatorRepRequestValidator.ts              |     100 |      100 |     100 |     100 |
  PutPasswordRequestValidator.ts                 |     100 |      100 |     100 |     100 |
  UserInformationRequestValidator.ts             |     100 |      100 |     100 |     100 |
 services                                        |   97.79 |     97.7 |     100 |   97.73 |
  IdService_Stub.ts                              |     100 |      100 |     100 |     100 |
  IdentifyCodeService.ts                         |     100 |      100 |     100 |     100 |
  LoginService.ts                                |   90.87 |       98 |     100 |   90.69 | 260-272,290-302,479,488
  LogoutService.ts                               |   97.91 |     87.5 |     100 |   97.77 | 60
  OperatorService.ts                             |      99 |    97.17 |     100 |   98.98 | 566,590,641,1261-1262,1290,1378
  PasswordService.ts                             |     100 |      100 |     100 |     100 |
  SessionService.ts                              |     100 |      100 |     100 |     100 |
  SmsVerificateService.ts                        |     100 |      100 |     100 |     100 |
  UserInfoService.ts                             |     100 |      100 |     100 |     100 |
 services/dto                                    |     100 |      100 |     100 |     100 |
  IdentifyCodeServiceDto.ts                      |     100 |      100 |     100 |     100 |
  LoginServiceDto.ts                             |     100 |      100 |     100 |     100 |
  LogoutServiceDto.ts                            |     100 |      100 |     100 |     100 |
  OperatorServiceDto.ts                          |     100 |      100 |     100 |     100 |
  PasswordServiceDto.ts                          |     100 |      100 |     100 |     100 |
  SessionServiceDto.ts                           |     100 |      100 |     100 |     100 |
  SmsVerificateServiceDto.ts                     |     100 |      100 |     100 |     100 |
  UserInfoServiceDto.ts                          |     100 |      100 |     100 |     100 |
-------------------------------------------------|---------|----------|---------|---------|---------------------------------

Test Suites: 28 passed, 28 total
Tests:       369 passed, 369 total
Snapshots:   0 total
Time:        138.877 s
Ran all test suites.
smit-akiyama commented 9 months ago

プルリクありがうございました。 プルリク内容は以下プルリクに混ぜ込んでdevelopブランチにマージしましたので、本プルリクはクローズいたします。 https://github.com/Personal-Data-Linkage-Module/pxr-operator-service/pull/18