Promotion dialogue silently fails if channel isn't selected

Perth-Artifactory / pledgeBot

Project pledge system operated through Slack

https://perart.io/pledgeBot

2 stars 0 forks source link

Promotion dialogue silently fails if channel isn't selected #2

Closed FletcherAU closed 10 months ago

FletcherAU commented 2 years ago

When the conversation selector isn't filled the promotion modal returns None for channel. This causes respond() to kick back an error.

The server responded with: {'ok': False, 'error': 'invalid_arguments', 'response_metadata': {'messages': ['[ERROR] missing required field: channel']}})

Instead the modal should kick back a validation error similar to updateData