Alegebra issues in MLS class

PetMetz / pymls

Python implementation of the dislocation contrast factor calculation reported by Martinez-Garcia, Leoni, and Scardi

Other

0 stars 0 forks source link

Alegebra issues in MLS class #9

Open PetMetz opened 1 year ago

PetMetz commented 1 year ago

Preliminary test writing for MLS interface show algebra errors in:

gamma2
delta
psi
phi

Trivial solution would be to rewrite with explicit for loops, speed be damned.

PetMetz commented 1 year ago

Fixed a bunch of this, but need to revisit testing

NB Ting distinguishes the subscript \alpha as corresponding with elements of the eigen vectors / values and points out that in general these won't be summed over.

PetMetz commented 1 year ago

I think I've caught all the algebra issues and written sufficient test coverage for this issue, however:

formation of phi_ijamnb in the contraction of Eijmn results in null terms where Martinez-Garcia, Leoni, & Scardi show finite values
Their implementation (matlab) may have different conventions for eignevalue solutions. numpy/scipy return normalized eignvectors by default. Not sure if this scaling influences the magnitude of the computed value.