This pull request addresses several compiler warnings issued by Clang. It also eliminates conversions.c, conversions.h, conversions.hcu, and conversions.hcl, replacing them with a single file conversions.hpp. This file, defining kIndex, kxPos, etc., can be included by cuda kernels by setting the preprocessor macro PV_RUN_ON_GPU; and can be included by ordinary CPU code by unsetting that macro.
Not all Clang warnings have been removed. Setting -Wunused-function (including -Wall) causes the .cu files to warn regarding PV::Response::completed(); and setting -Wunused-parameter (including -Wextra) causes numerous warnings of unused function arguments. It does not seem to be practical to eliminate these warnings.
This pull request addresses several compiler warnings issued by Clang. It also eliminates conversions.c, conversions.h, conversions.hcu, and conversions.hcl, replacing them with a single file conversions.hpp. This file, defining kIndex, kxPos, etc., can be included by cuda kernels by setting the preprocessor macro PV_RUN_ON_GPU; and can be included by ordinary CPU code by unsetting that macro.
Not all Clang warnings have been removed. Setting -Wunused-function (including -Wall) causes the .cu files to warn regarding PV::Response::completed(); and setting -Wunused-parameter (including -Wextra) causes numerous warnings of unused function arguments. It does not seem to be practical to eliminate these warnings.