search

PetarMarijanovic / RxActivityResult

Rx wrapper around Androids OnActivityResult
24 stars 8 forks source link

other lib #3

Closed Rainer-Lang closed 7 years ago

Rainer-Lang commented 7 years ago

Do you know this lib? https://github.com/VictorAlbertos/RxActivityResult

UPDATE: What are the differences? Pros/cons?

PetarMarijanovic commented 7 years ago

I believe that you'll be better off with using Victors library since it is more seasoned :) This is my take on it. I will try to keep it as simple as possible (and working of course), to learn something along the way and to spread the knowledge :)

Rainer-Lang commented 7 years ago

I like your convenience methods. Maybe it's possible for you to contribute to Victors lib with some of your ideas....?

PetarMarijanovic commented 7 years ago

I just did :) https://github.com/VictorAlbertos/RxActivityResult/pull/47

AlexTrotsenko commented 5 years ago

@PetarMarijanovic I can't agree with you, that VictorAlbertos lib is better nowdays :)

VictorAlbertos lib "helps" you to perform two things:

  1. Rx api to handle onActivityResult()
  2. Update ui of current activity in . subscribe(). when Rx task is done by handling state of currently active activity .

I believe, that standard LiveData does 2nd job better nowdays. Thus I would like to have simple lib, which does only Rx api part, e.g. task 1 in the list above.

I was about actually to create my own lib doing exactly what you lib already does. Likely I found your lib before doing this. I will try to use it and give the feedback. So far I like it exactly because of simplicity and doing only one dedicated task.

Also I like current approach with "helper fragment". As for me it is more elegant and safe then approach with "helper activity" in VictorAlbertos lib.

Btw, I have updated the same app to demonstrate how this lib works nicely with LiveData to acomplish before-mentioned job: https://github.com/PetarMarijanovic/RxActivityResult/pull/8