PeteGashek / puzzlebazar

Automatically exported from code.google.com/p/puzzlebazar
0 stars 0 forks source link

Short message does not show up when refreshing a page #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Right now, the #!settings-accounts page shows a dummy short message in 
onReveal and hides it in onHide.

However, if the user hits the refresh button while in that page the message 
goes away, indicating that onReveal is not processed.

Original issue reported on code.google.com by philippe.beaudoin on 16 Mar 2010 at 7:14

GoogleCodeExporter commented 9 years ago
This looks fixed with the refactoring of the presenters reveal/hide mechanism.

Original comment by philippe.beaudoin on 17 Mar 2010 at 8:06

GoogleCodeExporter commented 9 years ago
This occurs again on my laptop under Chrome. Need to check other environments.

It could be due to the fact that the SplitMainPresenter, that is responsible of 
handling the DisplayShortMessageEvent, is not yet bound, so it's not listening 
to the 
event.

Original comment by philippe.beaudoin on 18 Mar 2010 at 6:03

GoogleCodeExporter commented 9 years ago
Really fixed now. 

The problem was due to the fact that the event bus enques and delays handler 
registration when events are currently being 
processed. (see {@link 
com.google.gwt.event.shared.HandlerManager@addHandler()}) So if a presenter 
registers a handler in 
its onBind() method and a child fires the event in its onReveal() method, then 
the event might get lost because the 
handler is not officially registered yet.

Original comment by philippe.beaudoin on 25 Mar 2010 at 6:03