search

PeteGashek / puzzlebazar

Automatically exported from code.google.com/p/puzzlebazar
0 stars 0 forks source link

Get rid of subclasses overriding revealInParent() #79

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
It is probably simpler to have subclasses pass-up the event type during 
construction, and having the top level presenter class fire the event.

Original issue reported on code.google.com by philippe.beaudoin on 22 Mar 2010 at 8:08

GoogleCodeExporter commented 8 years ago

Original comment by philippe.beaudoin on 23 Mar 2010 at 5:22

GoogleCodeExporter commented 8 years ago

Original comment by philippe.beaudoin on 23 Mar 2010 at 5:28

GoogleCodeExporter commented 8 years ago

Original comment by philippe.beaudoin on 23 Mar 2010 at 5:29

GoogleCodeExporter commented 8 years ago 
The advantage of keeping this as a method is that it could let some presenter 
"add" 
themselves to a slot, instead of "setting" themselves. This would work 
especially well 
with Issue 91.

So maybe it's not such a great idea to get rid of revealInParent(). Although it 
could 
probably have a better name...

revealInParentSlot() maybe?

Original comment by philippe.beaudoin on 26 Mar 2010 at 7:32

GoogleCodeExporter commented 8 years ago 
Moved to GWTP:
http://code.google.com/p/gwt-platform/issues/detail?id=5

Original comment by philippe.beaudoin on 27 Mar 2010 at 5:57