search

PeteLawler / BeagleBrew

A Beaglebone Black fork of a Raspberry Pi Temperature Controller for homebrewing and sous vide cooking
1 stars 1 forks source link

Thermometer disconnect causes stale state #2

Closed PeteLawler closed 8 years ago

PeteLawler commented 8 years ago

If I have two vessels configured yet am only running one, and the thermometer for the second vessel is disconnected, the first vessel becomes 'uncontrollable' and seemingly stuck in the state left when the second thermometer was disconnected

PeteLawler commented 8 years ago

There's clearly a difference between configured and available thermometers. An alert of some type should happen if a thermometer goes offline and a decision (preconfigured?) should be taken as whether to stop the run on that device until further interaction.

PeteLawler commented 8 years ago

Note that the fix in f39b8bca12209427ebffa30b5cac609e5a6697f3 isn't particularly good as it won't turn off the heater. However, given this bug is about the system hanging on a disconnected sensor and not what to do when a sensor's disconnected, it's arguable that this could be (presuming the unntested fix actually does what it says) fixed.

PeteLawler commented 8 years ago

Certainly fix f39b8bc is producing visible output in the logs. I'm still getting a stale state, but I think this may be some other bug as well that I've not been able to triage into cause and not this. But I'm not too sure.

PeteLawler commented 8 years ago

I'm not entirely convinced this was causing the stale state, see #29, but it feels good to have a fix in place to ensure that things should progress if the sensor vanishes and a log message is properly generated. Closing.