Peter-Schorn / SoftPlayer

Control Spotify playback from your menu bar
https://www.soft-player.com/
MIT License
10 stars 1 forks source link

Status bar indicator for current saved track #6

Open martin-braun opened 1 year ago

martin-braun commented 1 year ago

Indicates already saved (liked) songs that are currently playing by displaying a different status bar icon. It requires to sink changes of the player manager's currentTrackIsSaved published-object to react within the AppDelegate and toggle the icon.

Addresses #2, although it's no heart icon, I'm not good with SVG paths, so I just show a Spotify-green note instead. Please consider improving.

martin-braun commented 1 year ago

Preview:

Screen Shot 2023-05-26 at 05 52 05

The note turns green when the current track is within your "Liked Songs" playlist. I didn't want it to be too distracting, so I choose to keep the circle itself original.

It will only pick up the change when the player state changes (started track), the pop over is opened or when it's toggled within the pop over itself, not when it's toggled in Spotify directly.

Peter-Schorn commented 1 year ago

The new icon that displays when a track is liked does not have sufficient contrast with a light menu bar. The green music note is too hard to make out.

Screenshot 2023-06-17 at 12 09 13 AM
martin-braun commented 1 year ago

@Peter-Schorn I picked the Spotify green and I wanted it to be not intrusive. I agree that it's too hard to read, though. Do you maybe have a suggestion how to improve it? I was thinking about drawing an outline to the note, but it would require to change the shape of the note, as the green part would get too tiny when not doing so.